Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] bundle fixel afd #63

Closed
wants to merge 4 commits into from

Conversation

grahamlittlephd
Copy link

@grahamlittlephd grahamlittlephd commented Feb 8, 2024

Describe your changes

Added module: Uses SCILPY to calculate mean AFD along a bundle.

Say which test data are used by your module

Using processing.zip, currently cannot fetch this data, need to test/update prior to merge

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

@AlexVCaron AlexVCaron changed the title New Module bundle/fixelafd [Module][WIP] bundle fixel afd Mar 8, 2024
@AlexVCaron AlexVCaron added the WIP label Mar 8, 2024
@AlexVCaron AlexVCaron changed the title [Module][WIP] bundle fixel afd [Module] bundle fixel afd Mar 8, 2024
@AlexVCaron AlexVCaron removed the WIP label Mar 8, 2024
@arnaudbore
Copy link
Contributor

Sorry @grahamlittlephd 👍 Thank you for your work
#155

@arnaudbore arnaudbore closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants