Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module] Freewater module #61

Merged
merged 20 commits into from May 14, 2024
Merged

Conversation

karanphil
Copy link
Contributor

@karanphil karanphil commented Feb 8, 2024

Describe your changes

I added a freewater module! It is really close to the NODDI module. @Manonedde @gagnonanthony

Also, I corrected a few typos in the documentation.

Say which test data are used by your module

It uses the commit_amico test data.

Checklist before requesting a review

  • Create the tool:
    • Edit ./modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./modules/nf-scil/<category>/<tool>/meta.yml
  • Generate the tests:
    • Edit ./tests/modules/nf-scil/<category>/<tool>/main.nf
    • Edit ./tests/modules/nf-scil/<category>/<tool>/nextflow.config
    • Add test data locally for tests with the fork repository
    • Generate the test infrastructure and md5sum for all outputs
  • Ensure the syntax is correct :
    • Check indentation abides with the rest of the library (don't hesitate to correct others !)
    • Lint everything. Ensure your variables have good names.

Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 💯

Copy link
Contributor

@Manonedde Manonedde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@AlexVCaron AlexVCaron changed the title Freewater module [Module][WIP] Freewater module Mar 8, 2024
@AlexVCaron AlexVCaron added WIP and removed WIP labels Mar 8, 2024
@AlexVCaron AlexVCaron changed the title [Module][WIP] Freewater module [Module] Freewater module Mar 8, 2024
@karanphil
Copy link
Contributor Author

I updated the tests for the new reconst/freewater module! Should be ready to re-review @Manonedde @gagnonanthony @arnaudbore

Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 😄 I added minor comments. It also seems that snapshots aren't generated for the output files (other than the kernels).

Copy link
Contributor

@gagnonanthony gagnonanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 💯

Copy link
Collaborator

@AlexVCaron AlexVCaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update your container to 2.0.2, then LGTM 🚢

@AlexVCaron AlexVCaron merged commit a5a3905 into scilus:main May 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants