New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Subworkflow] BundleSeg subworkflow. #146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagnonanthony
changed the title
[Subworkflows] RecoBundlesX/BundleSeg subworkflow.
[Subworkflow] RecoBundlesX/BundleSeg subworkflow.
May 10, 2024
AlexVCaron
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good on my end, I'll let @arnaudbore comment on functionality. Great work, you're a rockstar 🚀
arnaudbore
approved these changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM need a quick fix then 🎉
gagnonanthony
changed the title
[Subworkflow] RecoBundlesX/BundleSeg subworkflow.
[Subworkflow] BundleSeg subworkflow.
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add BundleSeg as a subworkflow to be chained with
nf-tractoflow
. It might not be the most efficient way, but I made the Atlas directory optional. If provided, it must abide by the structure convention specified in themeta.yml
. If not provided, the subworkflow will fetch the atlas and config archives directly from Zenodo.@AlexVCaron and @arnaudbore, I'm open to suggestions!
List test packages used by your module
tracking.zip
Checklist before requesting a review
./modules/nf-scil/<category>/<tool>/main.nf
./modules/nf-scil/<category>/<tool>/meta.yml
./tests/modules/nf-scil/<category>/<tool>/main.nf
./tests/modules/nf-scil/<category>/<tool>/nextflow.config