[WIP] Add Freesurfer container #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVCaron
requested changes
Apr 24, 2024
docker-bake.hcl
Outdated
| @@ -116,6 +116,10 @@ variable "SCILUS_TAG" { | |||
| variable "FLOWS_TAG" { | |||
| } | |||
|
|
|||
| variable "FS_VERSION" { | |||
There was a problem hiding this comment.
Suggested change
| variable "FS_VERSION" { | |
| variable "freesurfer-version" { |
Also move the variable definition higher, with the other dependencies (names are lowercase)
| ARG FREESURFER_VERSION | ||
|
|
||
| # shell settings | ||
| WORKDIR /root |
There was a problem hiding this comment.
Suggested change
| WORKDIR /root | |
| WORKDIR / |
docker-bake.hcl
Outdated
| target = "freesurfer-install" | ||
| contexts = { | ||
| freesurfer-base = "docker-image://${base-install-image}" | ||
| freesurfer-builder = "docker-image://${base-build-image}" |
There was a problem hiding this comment.
Remove, you don't have a build stage
docker-bake.hcl
Outdated
| freesurfer-builder = "docker-image://${base-build-image}" | ||
| } | ||
| args = { | ||
| FREESURFER_VERSION = "${fs-version}" |
There was a problem hiding this comment.
Suggested change
| FREESURFER_VERSION = "${fs-version}" | |
| FREESURFER_VERSION = "${freesurfer-version}" |
docker-bake.hcl
Outdated
| "type=registry,ref=${dockerhub-user-pull}/build-cache:scilus-deps", | ||
| "type=registry,ref=scilus/build-cache:scilus-deps" | ||
| ] | ||
| tags = notequal("", DEPS_TAG) ? stamp_tag("scilus/scilus-deps:${DEPS_TAG}", timestamp()) : [] |
There was a problem hiding this comment.
Suggested change
| tags = notequal("", DEPS_TAG) ? stamp_tag("scilus/scilus-deps:${DEPS_TAG}", timestamp()) : [] | |
| tags = notequal("", DEPS_TAG) ? stamp_tag("scilus/scilus-freesurfer:${DEPS_TAG}", timestamp()) : [] |
let's put this in a separate dockerhub repository.
| ENV MNI_PERL5LIB /usr/local/freesurfer/mni/share/perl5 | ||
| ENV PERL5LIB /usr/local/freesurfer/mni/share/perl5 | ||
|
|
||
| ENV FS_LICENSE='/license.txt' |
There was a problem hiding this comment.
Add the version to the common VERSIONS file, like the other dockerfiles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.