Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

finish CI move to GHA #1191

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Conversation

shimanek
Copy link

@shimanek shimanek commented Nov 11, 2023

Just poking around trying to finish #1074 and maybe make progress toward #1117. With this it seems like GitHub actions based CI is in a working state; publishing workflow obviously untested and so far remains unchanged from the draft by @kernc. Relevant to recent discussion around #847. Is this viable? What's left?

Passing checks here: shimanek#4

kernc and others added 25 commits October 4, 2021 15:03
setup.py: update trove classifiers

setup.py: use setuptools.find_packages()

setup.py: use version from git tag

Note to self: git-tag releases since 0.7.3 !!!

rm MANIFEST.in since handled by setuptools_scm

MNT: setup.py: add dev deps

Remove pyproject.toml and requirements.txt

We already have more versatile setup.py + setup.cfg

Add docs dependencies to setup.py

setup.py: Add project_urls, shown in PyPI sidebar

setup.py: Use SPDX license identifier

Remove doc/requirements.txt in favor of setup.extras_require

setup.py: add pytest-cov dev dependency

CI: Require pytest-xdist for 'test-code-parallel' make target
Add .github/PULL_REQUEST_TEMPLATE.md
Drop CI testing on python 3.6 -- it's EOL by end of the year.

Update README.rst CI badge

DOC: Fix error "Latexmk: Missing input file: 'tgtermes.sty' from line"

CI: Install in develop mode for Docs

Since `make -C doc doctest` is run from the project dir,
sphinx/Python may import the curdir skopt instead of the
installed one.

Install in develop mode to get skopt/_version.py file created.
The alternative would be to cd elsewhere before running make.
Remove media dir; use intro image from doc/image/bo-objective.png

DOC: Merge and extend README/Development into CONTRIBUTING.md

Point docs/development to CONTRIBUTING.md as the canonical source
To v0.22.* -- it was released in 2019.
Also this joblib/joblib#917 (comment)

Futher bump tested scikit-learn == 0.24.* -- it is old enough!

The alternative would be to pin equally ancient scipy to
avoid error:

> AttributeError: 'str' object has no attribute 'decode'
The test was "rediscovered" (in a failing state) by
renaming the test case that follows it.
np.int has been deprecated so changed to int
@pep8speaks
Copy link

Hello @shimanek! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 155:80: E501 line too long (88 > 79 characters)
Line 247:80: E501 line too long (85 > 79 characters)
Line 249:80: E501 line too long (96 > 79 characters)
Line 286:80: E501 line too long (87 > 79 characters)
Line 287:80: E501 line too long (86 > 79 characters)

Line 26:1: E402 module level import not at top of file
Line 27:1: E402 module level import not at top of file

Line 45:1: E402 module level import not at top of file

Line 52:1: E305 expected 2 blank lines after class or function definition, found 1
Line 52:80: E501 line too long (99 > 79 characters)

Line 22:1: E402 module level import not at top of file

Line 113:1: E402 module level import not at top of file

Line 51:1: E402 module level import not at top of file

Line 13:80: E501 line too long (83 > 79 characters)

Line 38:80: E501 line too long (81 > 79 characters)

Line 197:80: E501 line too long (82 > 79 characters)
Line 393:80: E501 line too long (82 > 79 characters)

Line 97:80: E501 line too long (83 > 79 characters)

Comment on lines +76 to +80
- name: Upload artifact
uses: actions/upload-artifact@v2
with:
name: package
path: dist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct.
At least one of the above steps MUST build the package, otherwise the dist directory is empty.

something around the following should work ...

      - name: Build package
        if: env.TEST_WITH_COVERAGE == 'true'
        run: |
          pip install --upgrade build
          python -m build --sdist --wheel --outdir dist/

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants