Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

[MRG] Change ExtraTreesRegressor criterion from 'mse' to 'squared_error' #1150

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jotoak
Copy link

@jotoak jotoak commented Feb 16, 2023

Changes are made to be compatible with scikit-learn version 1.0. Version bump of both scipy and numpy is also done. This pull request also requires #1148

skopt/learning/forest.py Outdated Show resolved Hide resolved
@ShamoX
Copy link

ShamoX commented Feb 22, 2023

It worked for me to use this patch. I simply used @jotoak repository as source of the package (requirements.txt file of my project):

scikit-optimize @ git+https://github.com/jotoak/scikit-optimize.git@master

For reference, the error I had occurred after the initialization steps and was:

sklearn.utils._param_validation.InvalidParameterError: The 'criterion' parameter of ExtraTreesRegressor must be a str among {'poisson', 'absolute_error', 'squared_error', 'friedman_mse'}. Got 'mse' instead.

I am running this on an Apple Silicon M2, and so I couldn't get back to an old version of sklearn.

jotoak and others added 3 commits February 22, 2023 16:59
Fix max line width

Co-authored-by: Roland Laurès <roland@laures-valdivia.net>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants