New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Release highlights 1.5 #29007

Merged

jeremiedbb merged 10 commits into scikit-learn:main from jeremiedbb:release-highlights-1.5

May 20, 2024

Member

jeremiedbb commented May 13, 2024 •

edited

No description provided.


          init

5f7d6ef

github-actions bot commented May 13, 2024 •

edited

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

_{Generated for commit: 5bdc853. Link to the linter CI: here}

jeremiedbb added 2 commits

May 17, 2024 16:21


          add highlights

9f10c23


          iter

f11be22

betatim reviewed

View reviewed changes

Member

betatim left a comment

Looking good. Two little grammar comments

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved


          Update examples/release_highlights/plot_release_highlights_1_5_0.py

42f2b7a

Co-authored-by: Tim Head <betatim@gmail.com>

jeremiedbb commented

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved


          Update examples/release_highlights/plot_release_highlights_1_5_0.py

524204b

jeremiedbb changed the title ~~[WIP] Release highlights 1.5~~ DOC Release highlights 1.5

github-actions bot added the Documentation label

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved


          Apply suggestions from code review

e516746

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

glemaitre reviewed

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

glemaitre approved these changes

View reviewed changes

Member

glemaitre left a comment

Only nitpicks. LGTM.


          Apply suggestions from code review

444218b

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>

jeremiedbb commented

View reviewed changes

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved


          Update examples/release_highlights/plot_release_highlights_1_5_0.py

19f17bc

lorentzenchr approved these changes

View reviewed changes

Member

lorentzenchr left a comment

Thanks for putting this together. Mostly optional suggestions.

examples/release_highlights/plot_release_highlights_1_5_0.py Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py Outdated Show resolved Hide resolved

examples/release_highlights/plot_release_highlights_1_5_0.py

+              # <sphx_glr_auto_examples_model_selection_plot_cost_sensitive_learning.py>`.
+              # %%
+              # Performance improvements in PCA

Member

lorentzenchr May 17, 2024

Not actionable: I know we are a bit thin with big new things and this is one of them. But we did not list the newton-cholesky solver in 1.2 as a highlight.

Member

thomasjpfan May 18, 2024

I think we should have promoted the newton-cholesky in 1.2.

If I put on my "developer relationships" hat on, I would add a new entry for newton-cholesky solver in the 1.2 highlights and link to it in the 1.5 highlights.

Member Author

jeremiedbb May 20, 2024

But we did not list the newton-cholesky solver in 1.2 as a highlight.

It could have but all the reviewers for the 1.2 highlights missed it, including me. That said there were already many entries in the 1.2 highlights and there's always a compromise to make.

I would add a new entry for newton-cholesky solver in the 1.2 highlights and link to it in the 1.5 highlights.

I don't think adding a new entry today in the 1.2 highlights is relevant. It's already not even accessible from the front page. I expect a very low traffic on this page now.

Member

lorentzenchr commented May 17, 2024

@scikit-learn/core-devs ping in case you want to have a look.

jeremiedbb and others added 2 commits

May 20, 2024 10:29


          Update examples/release_highlights/plot_release_highlights_1_5_0.py

d8cb520

Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>


          address comments

5bdc853

jeremiedbb mentioned this pull request

Release 1.5.0 #29054

Merged

14 tasks

Member Author

jeremiedbb commented May 20, 2024 •

edited

Alright, let's merge to not delay the release. If we want to do something about #29007 (comment), we can still open a separate PR and backport in 1.5.X, it's just doc anyway.

jeremiedbb merged commit be5316f into scikit-learn:main

30 checks passed

jeremiedbb added a commit to jeremiedbb/scikit-learn that referenced this pull request


          DOC Release highlights 1.5 (scikit-learn#29007)

Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>

jeremiedbb added a commit that referenced this pull request


          DOC Release highlights 1.5 (#29007)

0ac28ad

Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment