Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Allow values less than 1 for the gamma param of spectral clustering #27318

Conversation

nicolasdalsass
Copy link

@nicolasdalsass nicolasdalsass commented Sep 8, 2023

What does this implement/fix? Explain your changes.

In scikit-learn 1.1.0, the gamma value for spectral clustering was forced >=1.0
This is incorrect as low values (< 1) are very useful (and almost standard in fact)

This reallows >=0 values instead of >=1 real values

Any other comments?

This is fixed by 46623ef for versions >= 1.2.0 so there is no need to apply this on other branches

@nicolasdalsass nicolasdalsass force-pushed the bug/spectral_clustering_allowed_gammas branch from 90e2023 to 582de13 Compare September 8, 2023 08:54
@glemaitre
Copy link
Member

I am afraid that we are not going to make an new bug fixes release for 1.1.X.
This is fixed in scikit-learn 1.2.X+, so you can update scikit-learn.

@glemaitre glemaitre closed this Sep 11, 2023
@nicolasdalsass nicolasdalsass deleted the bug/spectral_clustering_allowed_gammas branch September 12, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants