Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add editable test #585

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

tests: add editable test #585

wants to merge 2 commits into from

Conversation

henryiii
Copy link
Contributor

@jwittbrodt or @maichmueller, any idea how to make this new test fail?

@henryiii
Copy link
Contributor Author

henryiii commented Aug 23, 2021 •
edited

I would hope this new test fails, and then #582 would be required to fix it.

@maichmueller
Copy link

@henryiii I could not get scikit-build to fail the editable install with the minimal python only package example from #546 . However, it did fail for a minimal cpp extension (pybind11) with subpackages. I have added that test case to my PR and I am testing whether the current skbuild version fails on that in the workflows. If it does, then I will re-add my fix and see if that resolves it.

@jwittbrodt
Copy link

Thanks a lot for looking into this. I also can't get my pure python example to fail anymore, seems some new version somewhere fixed that issue. But as @maichmueller said, it still fails for me if a pybind11 extension is involved.

@henryiii henryiii mentioned this pull request Dec 28, 2021
Open
@casperdcl casperdcl mentioned this pull request May 16, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@henryiii @maichmueller @jwittbrodt