Support Typescript #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getkey
force-pushed
the
ft/typescript
branch
2 times, most recently
from
a7a6fa5
to
1b0ffce
Compare
getkey
added a commit
to getkey/ble
that referenced
this pull request
May 30, 2021
Also sent the types upstream schteppe/poly-decomp.js#16
|
@schteppe it would be awesome to have these typedefs! Could you merge this PR and publish a new version to npm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing the types, I noticed the return values of
makeCCWandremoveCollinearPointswhere undocumented, so I amended the readme.