Add index for all filterable, sortable and searchable fields #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
Adapter: Elasticsearch
alexander-schranz
force-pushed
the
enhancement/index-filterable-fields
branch
5 times, most recently
from
20ea8f5
to
dd1dab2
Compare
alexander-schranz
force-pushed
the
enhancement/index-filterable-fields
branch
from
2076a3b
to
7f8d101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries on none indexed fields are slow: Reference: https://github.com/elastic/elasticsearch/pull/92606/files -> https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-index.html
So we should add index on all filterable and sortable fields also. This requires us to refractor how we search on the index as currently we did misuse
index: falseto make things not searchable. Which seems not the correct way.