Add GeoDistanceCondition and GeoBoundingBoxCondition #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
Adapter: Meilisearch
|
Thx for the pull request at current early state of the library we will not merge things into the core which are not part of all Adapters. Still we can keep this pull request open. It would be great if you could create an issue for this also and if you have some time add links to the specific search engines documentation. I may would create 2 issues for GeoDistance and GeoBoundingBox as it are 2 seperate features/conditions and we may can only implement the once which are currently supported by all engines. What we require is a list like this one: |
This was referenced Feb 20, 2024
alexander-schranz
added
help wanted
ker0x
force-pushed
the
feature/geo-conditions
branch
from
7bfeddb
to
33350c3
Compare
ker0x
force-pushed
the
feature/geo-conditions
branch
from
33350c3
to
9516c97
Compare
alexander-schranz
added
Adapter: Elasticsearch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce 2 new conditions:
GeoDistanceConditionandGeoBoundingBoxConditionGeoDistanceConditionGeoBoundingBoxCondition