Refactor to include ReflectinoClass to support better inheritance model #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance model" This reverts commit d7a8a04.
|
@schmittjoh this is a WIP, I will now work on the JMSAopBundle If you have any comments, please go quick, I have a limited time window to contribute to this code! |
|
Maybe I'm missing something, but why do we need to duplicate so much code? :) |
| * | ||
| * @return array<MethodInterceptorInterface> | ||
| */ | ||
| function loadInterceptors(\ReflectionClass $class, \ReflectionMethod $method); |
There was a problem hiding this comment.
This function's signature forces to create these codes
|
If you are not sure if it can be simplified more, just leave it as is, and I will take a look at it. |
|
you are welcome to simplify this code ;) but without changing method's signatures this is going to be hard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.