-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended cg lib: Traits and Interface support #23
base: master
Are you sure you want to change the base?
Conversation
@@ -1,4 +1,10 @@ | |||
.project | |||
.buildpath | |||
.settings/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 lines are speciifc to your dev setup, not to the project. You should ignore them locally (you can even put the rule once to apply it for the whole machine): https://help.github.com/articles/ignoring-files
I always find it weird to see a PR beign opened rewriting a library entirely without any previous discussion on it to know what the maintainer thinks about it... Note that I'm not the maintainer |
Hum, ye rewrite somehow sounds weird. It's more an extension that I needed and pushed back now. |
Well, if it is not BC (and it is not as it removes the 5.3 support for instance and drops some classes), it is not just an extension. |
Any news on this @schmittjoh ? Because I'm planning on releasing my fork as its own version. Thanks. |
Hey,
I needed a good codegen lib with traits and interface support. Your codegen lib was the best I found, though missing what I needed. I baked it in. All changes:
I would suggest a new name, because the library is hardly findable. New and better name probably is:
php-code-generator
orphp-codegen
. Because a new version is needed, I think this fits perfectly with a new name. How actively maintained is this project for this?I will use my fork for my current project. I think I will find another round of issues when using it from a particular project. At least in the early days.
In a perfect world:
Would love to hear feedback
gossi