Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scanning other formats #268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jazz-max
Copy link

fix #61 and #59
Update to latest zxing.js from yushulx/zxing-cpp-emscripten
fork and change ZXing._decode_qr to ZXing._decode_any how describe in #59

Update to latest zxing.js from yushulx/zxing-cpp-emscripten
fork
@orionlu0916
Copy link

fix #61 and #59 Update to latest zxing.js from yushulx/zxing-cpp-emscripten fork and change ZXing._decode_qr to ZXing._decode_any how describe in #59

@jazz-max I pulled your forked project and build it,
the QRcode and Barcode scanning works perfectly on PC browser(chromeV94.0.4606.61, windows10), which is awesome!
but when I tried it on (ios14+safari)
I got a black empty preview, just wondering if it caused by your change?
or it's a known issue which fixed already after your forked version?
how can I fix it with your forked project?

@orionlu0916
Copy link

fix #61 and #59 Update to latest zxing.js from yushulx/zxing-cpp-emscripten fork and change ZXing._decode_qr to ZXing._decode_any how describe in #59

@jazz-max I pulled your forked project and build it, the QRcode and Barcode scanning works perfectly on PC browser(chromeV94.0.4606.61, windows10), which is awesome! but when I tried it on (ios14+safari) I got a black empty preview, just wondering if it caused by your change? or it's a known issue which fixed already after your forked version? how can I fix it with your forked project?

@jazz-max NVM, it's an issue of safari's thing, your change is perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for scanning other formats
2 participants