Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for module service provider #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pratikpparikh
Copy link

@pratikpparikh pratikpparikh commented Aug 28, 2018

#16

Hi @larsga,

I have added support for adding namespaced provider modules. Please review and recommend changes, once this is approved I will check-in the group-by and experimental module function as well.

Regards,
Pratik Parikh

@larsga
Copy link
Collaborator

larsga commented Sep 9, 2018

Hmmmm. I don't really understand the purpose of this PR. What are "namespaced provider modules"? Why do we want it?

@pratikpparikh
Copy link
Author

pratikpparikh commented Sep 10, 2018

@larsga the logic that you are using for creating modules, I am calling them namespaced provider. Just a way to address them. No biggy, another thing that you will notice is that I am using a service provider which was added in JDK6+ onwards. Also at the minimum, if you don't find any other value in the PR then please look at the build.gradle change that I did which is very simple. I use JDK 10 which requires all the libraries that I use to have either the automatic module name or module-info. I added the automatic module name, in this case, to help to utilize it in JDK 9+. I would also request you to consider using the service provider so that you allow others to build the meaningful extension without having to touch the parsercontext and other core classes as they need. Hoping this explanation helps a bit about my contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants