Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NOJIRA Fix consumer-rules to keep com.nimbusds.jose JWK classes #105

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pklawikowski-schibsted
Copy link
Contributor

One of Klarta devs reported issue that when he was using minify the SDK was unstable and it throwed such error:

else if (superclass == TypeToken.class) {
      throw new IllegalStateException("TypeToken must be created with a type argument: new TypeToken<...>() {}; "
          + "When using code shrinkers (ProGuard, R8, ...) make sure that generic signatures are preserved.");
    }

The problem starts in:

schibstedAccountApi.getJwks { ... }

Is located in:

com.nimbusds.jose.shaded.gson.reflect.TypeToken 

which is used during parsing:

com.nimbusds.jose.util.JSONObjectUtils.parse(...)

and results in such info:

Token error response: IdTokenNotValid(cause=UnexpectedError(message=Failed to fetch JWKS to validate ID Token))

The solution is pretty simple - lets keep classes inside this dependency.
Fix is confirmed with app dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants