Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PerformingGroup as an expected type for the property actor #3352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gmackenz
Copy link
Contributor

As discussed in #3185 cast information can contain groups (comedy, musical, etc.) as well as individual people.

As discussed in schemaorg#3185 cast information can contain groups (comedy, musical, etc.) as well as individual people.
@WeaverStever
Copy link

Seems to have missed https://schema.org/Play

See also
#2918

@gmackenz
Copy link
Contributor Author

Seems to have missed https://schema.org/Play

See also #2918

Seems like a misinterpretation (as I see it) of Play as that is the source CreativeWork which is being performed in a specific TheaterEvent or BroadcastEvent. So a specific actor is linked to the event not to the play. Usually the Play is a singular conceptual instance that is performed over time in many performances.

@salikh
Copy link

salikh commented Aug 4, 2023

I believe .actor should also allow the mediator type https://schema.org/PerformanceRole as the value, as the JSON-LD example use already has it, but the formal description does not list it.

:rangeIncludes :Person ;
rdfs:comment "An actor, e.g. in TV, radio, movie, video games etc., or in an event. Actors can be associated with individual items or with a series, episode, clip." .
:rangeIncludes :Person,
:PerformingGroup ;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about also adding :PerformanceRole here to make the JSON-LD usage example consistent with schema? (See data/examples.txt LL10845-10860)

Copy link
Contributor Author

@gmackenz gmackenz Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Role is meant to be applicable to any property, not just actor, as per the post announcing Role in 2014

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see! Sorry for missing that, and thanks for the explanation!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :)

Copy link

github-actions bot commented Nov 2, 2023

This pull request is being nudged due to inactivity.

@github-actions github-actions bot added the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Nov 2, 2023
@danbri
Copy link
Contributor

danbri commented Nov 2, 2023 via email

@gmackenz
Copy link
Contributor Author

gmackenz commented Nov 2, 2023

Where are we with this one?

I believe there has been no actionable pushback on the change to allow PerformingGroup as an actor, so good to go? I suppose we could update the description a little.

@github-actions github-actions bot removed the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants