Convert attenuation from centibels to decibels #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spirrwell
pushed a commit
to Spirrwell/eduke32-mirror
that referenced
this pull request
Mar 17, 2024
Incorporates this upstream PR which has yet to be merged. schellingb/TinySoundFont#85
dibollinger
pushed a commit
to dibollinger/amcduke32
that referenced
this pull request
Apr 6, 2024
Incorporates this upstream PR which has yet to be merged. schellingb/TinySoundFont#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attenuation is currently used as a decibel value. However, the SoundFont Technical Specification describes initialAttenuation as being in centibels. Due to this, regions with a nonzero attenuation value are much quieter than they should be. This simple fix divides the attenuation by 10 when calculating note gain to perform the conversion.
Note how the lead organ in this MIDI (about 20 seconds in) is far quieter before the change, but after the change, it much more closely resembles FluidSynth's output.
Before fix:
tsf_before.mp4
After fix:
tsf_after.mp4
FluidSynth for reference:
fluidsynth.mp4