Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: edit->Add compass #285

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

FIX: edit->Add compass #285

wants to merge 2 commits into from

Conversation

xulman
Copy link
Contributor

@xulman xulman commented Sep 3, 2020

  • is not asking/complaining for Vector3f, and shows dialog instead...
  • has nicer dialog
  • optionally be in the TL corner as overlay
  • optionally be as a part of the scene
  • tiny bit of refactoring
    Screenshot_20200903_170226

@xulman xulman mentioned this pull request Sep 3, 2020
Open
@xulman
Copy link
Contributor Author

xulman commented Sep 3, 2020

I would not merge until issue #286 is resolved

@xulman
FIX: edit->Add compass can:
4907cf2 
- is not asking/complaining for Vector3f, and shows dialog instead...
- has nicer dialog
- optionally be in the TL corner as overlay
- optionally be as a part of the scene
- tiny bit of refactoring
@xulman
CHG: overlay compass is a box
8fae164
@xulman
Copy link
Contributor Author

xulman commented Oct 9, 2020 •
edited

rebased against master

I gave you all I had regarding the orientation compass (as three-axes in the centre, as a box in the corner, rotations fixed-syncing with camera)

the stage is yours now

@kephale kephale mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@xulman