Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(chromatic): fix rebuild not providing storybook url by force rebuild everytime #3777

Merged
merged 1 commit into from
May 15, 2024

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented May 14, 2024

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Seems like there is an issue with chromatic on deploy. When no build is required as it was already done chromatic github action is skipping it and by doing so it doesn't provide the output storybookUrl. In order to fix this we force the build.

I opened an issue on chromatic: chromaui/chromatic-cli#983

Screenshot 2024-05-14 at 17 56 00

@matthprost matthprost requested review from lisalupi and a team May 14, 2024 15:57
@matthprost matthprost self-assigned this May 14, 2024
@matthprost matthprost requested review from Lawndlwd and removed request for a team May 14, 2024 15:57
Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: 6c3ab45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (d23bfe6) to head (6c3ab45).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3777   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files         190      190           
  Lines        4206     4206           
  Branches      632      632           
=======================================
  Hits         3768     3768           
- Misses        320      321    +1     
+ Partials      118      117    -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23bfe6...6c3ab45. Read the comment docs.

@matthprost matthprost merged commit 39cecd9 into main May 15, 2024
22 checks passed
@matthprost matthprost deleted the ci/fix-chromatic-rebuild branch May 15, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants