Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Navigation): add functionality to disable expand #3776

Merged
merged 1 commit into from
May 17, 2024

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented May 14, 2024

Summary

Type

  • Enhancement

Summarise concisely:

What is expected?

New prop initialAllowNavigationResize on <NavigationProvider /> and serving allowNavigationResize and setAllowNavigationResize through useNavigation()

Screenshots

without changing any props (can resize):
Screenshot 2024-05-14 at 16 54 57

using initialAllowNavigationResize={false} (cannot resize):
Screenshot 2024-05-14 at 16 55 07

Also small fix, before:
Screenshot 2024-05-14 at 16 57 19

After:
Screenshot 2024-05-14 at 17 06 27

@matthprost matthprost added the enhancement New feature or request label May 14, 2024
@matthprost matthprost requested a review from a team May 14, 2024 15:20
@matthprost matthprost self-assigned this May 14, 2024
@matthprost matthprost requested review from johnrazeur and Loriick and removed request for a team May 14, 2024 15:20
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: d4ee517

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ultraviolet/plus Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (cd1bf10) to head (4bea089).

Current head 4bea089 differs from pull request most recent head d4ee517

Please upload reports for the commit d4ee517 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3776      +/-   ##
==========================================
- Coverage   89.74%   89.58%   -0.17%     
==========================================
  Files         191      190       -1     
  Lines        4272     4206      -66     
  Branches      638      632       -6     
==========================================
- Hits         3834     3768      -66     
  Misses        321      321              
  Partials      117      117              

see 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1bf10...d4ee517. Read the comment docs.

@matthprost matthprost enabled auto-merge (squash) May 17, 2024 10:38
@matthprost matthprost merged commit a959390 into main May 17, 2024
10 checks passed
@matthprost matthprost deleted the fix/navigation-expand branch May 17, 2024 14:07
@github-actions github-actions bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants