Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Toggle): error state #3775

Merged
merged 2 commits into from
May 16, 2024
Merged

feat(Toggle): error state #3775

merged 2 commits into from
May 16, 2024

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Feature

Summarise concisely:

What is expected?

<Toggle />: Added prop error

@lisalupi lisalupi added the enhancement New feature or request label May 14, 2024
@lisalupi lisalupi requested review from PetmePant, matthprost, mhervouet and a team May 14, 2024 15:09
@lisalupi lisalupi self-assigned this May 14, 2024
@lisalupi lisalupi requested review from DorianMaliszewski and removed request for a team May 14, 2024 15:09
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: 705cdfe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lisalupi lisalupi changed the title feat: toggle error state feat(Toggle): error state May 14, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.60%. Comparing base (1bb8016) to head (705cdfe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3775      +/-   ##
==========================================
+ Coverage   89.58%   89.60%   +0.01%     
==========================================
  Files         190      190              
  Lines        4206     4214       +8     
  Branches      632      632              
==========================================
+ Hits         3768     3776       +8     
- Misses        320      321       +1     
+ Partials      118      117       -1     
Files Coverage Δ
packages/form/src/components/ToggleField/index.tsx 46.15% <100.00%> (+4.48%) ⬆️
packages/ui/src/components/Toggle/index.tsx 98.03% <100.00%> (+0.31%) ⬆️
packages/ui/src/components/ToggleGroup/index.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb8016...705cdfe. Read the comment docs.

@lisalupi lisalupi requested a review from matthprost May 15, 2024 15:40
@lisalupi lisalupi merged commit 8ecd1b0 into main May 16, 2024
12 checks passed
@lisalupi lisalupi deleted the feat/toggle-error-state branch May 16, 2024 13:47
@github-actions github-actions bot mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants