Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: font size on inputs #3773

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: font size on inputs #3773

merged 1 commit into from
May 16, 2024

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Refactor

Summarise concisely:

What is expected?

Font-size changes for small and medium inputs : 14px instead of 16px

The following changes were made:

  1. Changed font-size front "body" to "bodySmall" for inputs & their label when size="medium" or "small"

Relevant logs and/or screenshots

Page TextInputV2
Before Capture d’écran 2024-05-14 à 12 02 08
After Capture d’écran 2024-05-14 à 12 01 39

@lisalupi lisalupi requested review from PetmePant, matthprost, mhervouet and a team May 14, 2024 10:06
@lisalupi lisalupi self-assigned this May 14, 2024
@lisalupi lisalupi requested review from alexandre-combemorel and removed request for a team May 14, 2024 10:06
Copy link

changeset-bot bot commented May 14, 2024

🦋 Changeset detected

Latest commit: d51240c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.59%. Comparing base (39cecd9) to head (d51240c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3773   +/-   ##
=======================================
  Coverage   89.58%   89.59%           
=======================================
  Files         190      190           
  Lines        4206     4210    +4     
  Branches      632      633    +1     
=======================================
+ Hits         3768     3772    +4     
  Misses        321      321           
  Partials      117      117           
Files Coverage Δ
packages/form/src/components/DateField/index.tsx 54.16% <ø> (ø)
packages/ui/src/components/NumberInputV2/index.tsx 81.48% <100.00%> (+0.71%) ⬆️
packages/ui/src/components/TagInput/index.tsx 93.26% <100.00%> (+0.06%) ⬆️
packages/ui/src/components/TextInputV2/index.tsx 93.10% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39cecd9...d51240c. Read the comment docs.

@lisalupi lisalupi merged commit 503aad3 into main May 16, 2024
12 checks passed
@lisalupi lisalupi deleted the fix/input-font-size branch May 16, 2024 13:48
@github-actions github-actions bot mentioned this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants