Feat/add fallback font theme #3748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2024 16:11
🦋 Changeset detectedLatest commit: 6f05b7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
matthprost
requested changes
May 3, 2024
| @@ -371,7 +371,7 @@ export const darkTheme = { | |||
| theme: 'dark', | |||
| typography: { | |||
| body: { | |||
| fontFamily: 'Inter', | |||
| fontFamily: 'Inter, sans-serif', | |||
There was a problem hiding this comment.
As written on top of each files those are generated based on what design send us back from figma tokens and they should not be manually edited. If you want to change this you need to change it from figma directly or see with a designer to do so.
There was a problem hiding this comment.
I didn't check properly the top of the file. I will have a look with designer or eventually check the script token generation
|
This is what it look like when its broken, @PetmePant 
|
|
The update has been merged here: #3802 You can rebase to check changes or close the PR 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add matching fallback font in case fonts are not yet loaded
Type
What is expected?
If fonts fail to load or are not yet loaded, then it should display the closest type of font
Based on google font fallback