Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpcgw): add support for triggering ssh keys refresh #2567

Merged
merged 4 commits into from May 16, 2024

Conversation

yfodil
Copy link
Contributor

@yfodil yfodil commented May 13, 2024

No description provided.

@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels May 13, 2024
@yfodil yfodil self-assigned this May 13, 2024
@yfodil yfodil requested a review from remyleone as a code owner May 13, 2024 09:44
@yfodil yfodil linked an issue May 13, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 71.22%. Comparing base (fe86049) to head (3fd1d2b).
Report is 56 commits behind head on master.

Files Patch % Lines
internal/services/vpcgw/public_gateway.go 40.00% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2567      +/-   ##
==========================================
- Coverage   71.43%   71.22%   -0.22%     
==========================================
  Files         277      329      +52     
  Lines       35875    33029    -2846     
==========================================
- Hits        25628    23525    -2103     
+ Misses       8028     7226     -802     
- Partials     2219     2278      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax added this pull request to the merge queue May 16, 2024
Merged via the queue into scaleway:master with commit 1b42618 May 16, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scaleway_vpc_public_gateway: add a field to trigger ssh keys refresh
3 participants