Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cockpit): add support for alert manager #2562

Merged

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented May 2, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 71.29%. Comparing base (fe86049) to head (130ff49).
Report is 61 commits behind head on master.

Files Patch % Lines
internal/services/cockpit/alert_manager.go 78.46% 22 Missing and 20 partials ⚠️
internal/verify/email.go 78.57% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2562      +/-   ##
==========================================
- Coverage   71.43%   71.29%   -0.15%     
==========================================
  Files         277      330      +53     
  Lines       35875    33254    -2621     
==========================================
- Hits        25628    23709    -1919     
+ Misses       8028     7245     -783     
- Partials     2219     2300      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 force-pushed the feat/cockpit-add-support-for-alert-manager branch from 94294b8 to 3720cd9 Compare May 2, 2024 13:30
@jremy42 jremy42 self-assigned this May 2, 2024
@jremy42 jremy42 marked this pull request as ready for review May 2, 2024 13:49
@jremy42 jremy42 requested a review from remyleone as a code owner May 2, 2024 13:49
@jremy42 jremy42 force-pushed the feat/cockpit-add-support-for-alert-manager branch 2 times, most recently from b7b8f47 to 9da87ec Compare May 14, 2024 12:46
@jremy42 jremy42 force-pushed the feat/cockpit-add-support-for-alert-manager branch 4 times, most recently from fe3e43f to 2b72b36 Compare May 15, 2024 08:44
@jremy42 jremy42 force-pushed the feat/cockpit-add-support-for-alert-manager branch from 2b72b36 to 2102303 Compare May 15, 2024 12:43
@yfodil yfodil changed the title Feat/cockpit add support for alert manager feat(cockpit): add support for alert manager May 15, 2024
@yfodil yfodil added enhancement observability Cockpit observability issues, bugs and feature requests labels May 15, 2024
docs/resources/cockpit_alert_manager.md Show resolved Hide resolved
internal/services/cockpit/alert_manager.go Outdated Show resolved Hide resolved
internal/services/cockpit/alert_manager.go Outdated Show resolved Hide resolved
internal/services/cockpit/alert_manager.go Show resolved Hide resolved
internal/services/cockpit/alert_manager.go Outdated Show resolved Hide resolved
internal/services/cockpit/alert_manager.go Outdated Show resolved Hide resolved
@jremy42 jremy42 force-pushed the feat/cockpit-add-support-for-alert-manager branch 2 times, most recently from a30501b to 46d74ac Compare May 16, 2024 09:43
@jremy42 jremy42 added the priority:high New features label May 16, 2024
docs/resources/cockpit_alert_manager.md Outdated Show resolved Hide resolved
docs/resources/cockpit_alert_manager.md Show resolved Hide resolved
docs/resources/cockpit_alert_manager.md Outdated Show resolved Hide resolved
internal/services/cockpit/alert_manager.go Outdated Show resolved Hide resolved
internal/services/cockpit/alert_manager.go Outdated Show resolved Hide resolved
internal/services/cockpit/alert_manager.go Outdated Show resolved Hide resolved
@jremy42 jremy42 force-pushed the feat/cockpit-add-support-for-alert-manager branch from 02b2df0 to ec687ce Compare May 17, 2024 10:38
@jremy42 jremy42 force-pushed the feat/cockpit-add-support-for-alert-manager branch from ec687ce to 6789a95 Compare May 17, 2024 12:51
@jremy42 jremy42 force-pushed the feat/cockpit-add-support-for-alert-manager branch from 6eee8b7 to 3f5a8ce Compare May 22, 2024 12:54
@yfodil yfodil added this pull request to the merge queue May 22, 2024
Merged via the queue into scaleway:master with commit c3109e5 May 22, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement observability Cockpit observability issues, bugs and feature requests priority:high New features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants