Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lb):clean up lb documentation #2421

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix(lb):clean up lb documentation #2421

wants to merge 3 commits into from
+116 −55

Conversation

Laure-di
Copy link
Contributor

close #1695

@Laure-di Laure-di force-pushed the fix/clean-doc-lb branch 2 times, most recently from edadcf2 to 50250fb Compare February 26, 2024 16:19
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.74%. Comparing base (7cf136f) to head (72d69e6).
Report is 3 commits behind head on master.

❗ Current head 72d69e6 differs from pull request most recent head 03a79f4. Consider uploading reports for the commit 03a79f4 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2421      +/-   ##
==========================================
- Coverage   73.78%   73.74%   -0.04%     
==========================================
  Files         229      229              
  Lines       35699    35761      +62     
==========================================
+ Hits        26339    26371      +32     
- Misses       7096     7115      +19     
- Partials     2264     2275      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laure-di Laure-di force-pushed the fix/clean-doc-lb branch 4 times, most recently from 03a79f4 to 5c267e1 Compare February 27, 2024 15:56
@Laure-di Laure-di self-assigned this Feb 27, 2024
@Laure-di Laure-di marked this pull request as ready for review February 27, 2024 16:44
remyleone
remyleone reviewed Feb 29, 2024
View reviewed changes
docs/resources/lb.md Outdated
### Scaleway Load Balancer with multiple private_network

```terraform
resource "scaleway_lb" "main" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you have self contained examples that can be copy and pasted in a stand alone way? You can see a preview of the document here: https://registry.terraform.io/tools/doc-preview

@Laure-di Laure-di marked this pull request as draft March 7, 2024 16:11
@remyleone remyleone assigned yfodil and Laure-di and unassigned Laure-di Apr 10, 2024
@remyleone remyleone added documentation load-balancer Load-balancer issues, bugs and feature requests priority:high New features labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Laure-di Laure-di

@yfodil yfodil

Labels
documentation load-balancer Load-balancer issues, bugs and feature requests priority:high New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs(scaleway_lb): clean up doc
4 participants
@Laure-di @codecov-commenter @remyleone @yfodil