Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): folder resource #2197

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Oct 31, 2023

This will remain as draft for now, it still has issues with unexpected plan.
Example:

  • Step1:
resource scaleway_secret_folder secret {
  name = "myfolder"
}

resource scaleway_secret secret {
  path = scaleway_secret_folder.folder.full_path
  name = "secret"
}
  • Step2:
resource "scaleway_secret" "secret" {
  name = "secret"
}

Plan:

Terraform will perform the following actions:

  # scaleway_secret.secret will be updated in-place
  ~ resource "scaleway_secret" "secret" {
        id            = "fr-par/fb07b2f8-a3d5-4cb8-931f-8522ad4f28c5"
        name          = "secret"
      ~ path          = "/my_folder" -> "/"
        # (7 unchanged attributes hidden)
    }

  # scaleway_secret_folder.folder will be destroyed
  # (because scaleway_secret_folder.folder is not in configuration)
  - resource "scaleway_secret_folder" "folder" {
      - full_path  = "/my_folder" -> null
      - id         = "fr-par/3b2b9415-83b9-4e2f-9f5a-6e4d2c1ccc2b" -> null
      - name       = "my_folder" -> null
      - path       = "/" -> null
      - project_id = "ee7bd9e1-9cbd-4724-b2f4-19e50f3cf38b" -> null
      - region     = "fr-par" -> null
    }

In reality the secret will be deleted as it is inside the folder

@Codelax Codelax added enhancement secret Managed Secret Manager issues, bugs and feature requests labels Oct 31, 2023
@Codelax Codelax self-assigned this Oct 31, 2023
@Codelax Codelax linked an issue Dec 21, 2023 that may be closed by this pull request
@remyleone remyleone added the priority:lowest Lowest priority such as new ideas and unproved/unrequested features label Jan 11, 2024
@leohubert
Copy link

leohubert commented Feb 26, 2024

any ETA about this subject ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority:lowest Lowest priority such as new ideas and unproved/unrequested features secret Managed Secret Manager issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support managing Secret Manager folders
3 participants