fix(instance): support snapshot based instance #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tormath1
force-pushed
the
tormath1/instance-snapshot
branch
from
bdc9f1a
to
7f521e5
Compare
Codelax
reviewed
May 20, 2024
| serverType *instance.ServerType | ||
| ) | ||
| if args.Image != "none" { | ||
| getImageResponse, err := apiInstance.GetImage(&instance.GetImageRequest{ |
There was a problem hiding this comment.
getImageResponse is shadowing the one created in previous context.
Suggested change
| getImageResponse, err := apiInstance.GetImage(&instance.GetImageRequest{ | |
| var err error | |
| getImageResponse, err = apiInstance.GetImage(&instance.GetImageRequest{ |
|
|
||
| serverType := getServerType(apiInstance, serverReq.Zone, serverReq.CommercialType) | ||
| serverType := getServerType(apiInstance, serverReq.Zone, serverReq.CommercialType) |
There was a problem hiding this comment.
serverType shadows the one created in previous context
Suggested change
| serverType := getServerType(apiInstance, serverReq.Zone, serverReq.CommercialType) | |
| serverType = getServerType(apiInstance, serverReq.Zone, serverReq.CommercialType) |
There was a problem hiding this comment.
Oops thanks a lot. Missed that. That should explain the failing CI.
This PR allow users to create an instance from a snapshot directly without creating an image. It's already supported by the APIs. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/instance-snapshot
branch
from
7f521e5
to
ad04273
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In this PR I tried to allow the CLI to deploy an instance directly from a snapshot without calling the marketplace API.
Community Note
Release note for CHANGELOG: