Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/core handle deprecated method #3786

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Apr 23, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:


@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.12%. Comparing base (5bf53e0) to head (9ef9178).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3786      +/-   ##
==========================================
- Coverage   75.45%   73.12%   -2.34%     
==========================================
  Files         202      280      +78     
  Lines       44323    49597    +5274     
==========================================
+ Hits        33444    36266    +2822     
- Misses       9653    11847    +2194     
- Partials     1226     1484     +258     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 force-pushed the feat/core-handle-deprecated-method branch from 88b1887 to 296e2c9 Compare April 25, 2024 14:45
@jremy42 jremy42 force-pushed the feat/core-handle-deprecated-method branch from bc99ac9 to 6547a64 Compare April 26, 2024 12:36
@jremy42 jremy42 force-pushed the feat/core-handle-deprecated-method branch from 6547a64 to 9ef9178 Compare April 26, 2024 12:46
@jremy42 jremy42 marked this pull request as ready for review April 26, 2024 12:53
{{ rpad $command.Name .NamePadding }} {{ if $command.Short }}{{ $command.Short }}{{end}}
{{- end }}
{{ rpad $command.Name .NamePadding }}
{{- if $command.Deprecated }}{{ if $command.Short }}{{ $command.Short }} (Deprecated){{ end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix alignement

Suggested change
{{- if $command.Deprecated }}{{ if $command.Short }}{{ $command.Short }} (Deprecated){{ end }}
{{- if $command.Deprecated }} {{ if $command.Short }}{{ $command.Short }} (Deprecated){{ end }}

Comment on lines +6 to +10
AVAILABLE COMMANDS:
a short server
server short server
b short server (Deprecated)
engine short engine (Deprecated)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Columns are misaligned

Suggested change
AVAILABLE COMMANDS:
a short server
server short server
b short server (Deprecated)
engine short engine (Deprecated)
AVAILABLE COMMANDS:
a short server
server short server
b short server (Deprecated)
engine short engine (Deprecated)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants