Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(object): basic CRUD support for buckets #3588

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(object): basic CRUD support for buckets #3588

wants to merge 3 commits into from

Conversation

Mia-Cross
Copy link
Contributor

Closes #3167

@Mia-Cross Mia-Cross added enhancement object Object storage issues, bugs and feature requests priority:medium Improvements that are not the main priority labels Jan 10, 2024
@Mia-Cross Mia-Cross self-assigned this Jan 10, 2024
@Mia-Cross Mia-Cross changed the title feat(object): basic CRUD support for buckets suppor feat(object): basic CRUD support for buckets support Jan 10, 2024
@Mia-Cross Mia-Cross changed the title feat(object): basic CRUD support for buckets support feat(object): basic CRUD support for buckets Jan 10, 2024
@Mia-Cross Mia-Cross force-pushed the object_bucket_support branch 6 times, most recently from 966330c to 8907a06 Compare March 4, 2024 16:32
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024 •
edited

Codecov Report

Attention: Patch coverage is 68.30709% with 161 lines in your changes are missing coverage. Please review.

Project coverage is 72.15%. Comparing base (5bf53e0) to head (90d7eea).
Report is 67 commits behind head on master.

Files Patch % Lines
internal/namespaces/object/v1/custom_bucket.go 75.45% 64 Missing and 31 partials ⚠️
internal/core/testing_recorder.go 0.00% 24 Missing and 1 partial ⚠️
internal/namespaces/object/v1/s3_helpers.go 65.57% 15 Missing and 6 partials ⚠️
internal/core/testing.go 0.00% 20 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3588      +/-   ##
==========================================
- Coverage   75.45%   72.15%   -3.31%     
==========================================
  Files         202      283      +81     
  Lines       44323    50841    +6518     
==========================================
+ Hits        33444    36683    +3239     
- Misses       9653    12631    +2978     
- Partials     1226     1527     +301

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mia-Cross Mia-Cross marked this pull request as ready for review March 5, 2024 14:19
@Mia-Cross Mia-Cross force-pushed the object_bucket_support branch 3 times, most recently from 29949cc to 7625dd4 Compare April 29, 2024 09:55
@Mia-Cross Mia-Cross force-pushed the object_bucket_support branch 2 times, most recently from 62a1e3c to 7cfbce7 Compare May 7, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codelax Codelax Codelax left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Mia-Cross Mia-Cross

Labels
enhancement object Object storage issues, bugs and feature requests priority:medium Improvements that are not the main priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement minimal CRUD support for buckets
3 participants
@Mia-Cross @codecov-commenter @Codelax