Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move config loading to internal/platform #3217

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Jun 15, 2023

No description provided.

@Codelax Codelax added the core label Jun 15, 2023
@Codelax Codelax self-assigned this Jun 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3217 (7d3df1d) into master (a5bea53) will increase coverage by 0.01%.
The diff coverage is 89.33%.

@@            Coverage Diff             @@
##           master    #3217      +/-   ##
==========================================
+ Coverage   75.61%   75.63%   +0.01%     
==========================================
  Files         177      177              
  Lines       38287    38445     +158     
==========================================
+ Hits        28951    29078     +127     
- Misses       8272     8300      +28     
- Partials     1064     1067       +3     
Impacted Files Coverage Δ
internal/interactive/utils.go 45.00% <ø> (ø)
internal/core/context.go 53.09% <60.00%> (+0.80%) ⬆️
internal/namespaces/k8s/v1/custom_cluster.go 79.57% <73.49%> (-2.78%) ⬇️
internal/human/marshal.go 72.67% <100.00%> (ø)
internal/namespaces/info/custom.go 62.31% <100.00%> (ø)
internal/namespaces/instance/v1/instance_cli.go 87.85% <100.00%> (+0.32%) ⬆️
internal/namespaces/vpc/v1/vpc_cli.go 89.76% <100.00%> (ø)
...l/namespaces/webhosting/v1alpha1/webhosting_cli.go 83.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

@remyleone remyleone added the priority:low Low priority such as UX improvements and esthetics label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core priority:low Low priority such as UX improvements and esthetics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants