Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): add web urls #2979

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat(instance): add web urls #2979

wants to merge 7 commits into from

Conversation

Codelax
Copy link
Member

@Codelax Codelax commented Mar 30, 2023

Waiting for #2971

@Codelax Codelax added the instance Instance issues, bugs and feature requests label Mar 30, 2023
@Codelax Codelax self-assigned this Mar 30, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2979 (f33efe1) into master (8e6e433) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2979      +/-   ##
==========================================
+ Coverage   75.69%   75.71%   +0.01%     
==========================================
  Files         177      178       +1     
  Lines       38834    38862      +28     
==========================================
+ Hits        29396    29424      +28     
  Misses       8363     8363              
  Partials     1075     1075
Impacted Files Coverage Δ
internal/namespaces/instance/v1/custom.go 98.25% <100.00%> (+0.04%) ⬆️
internal/namespaces/instance/v1/custom_web.go 100.00% <100.00%> (ø)

@Codelax Codelax marked this pull request as ready for review July 4, 2023 09:14
@remyleone remyleone added this pull request to the merge queue Dec 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2023
@remyleone remyleone added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@remyleone remyleone added this pull request to the merge queue Jan 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 11, 2024
@remyleone remyleone added this pull request to the merge queue Jan 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2024
@remyleone remyleone added the priority:lowest Lowest priority such as new ideas and unproved/unrequested features label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remyleone remyleone remyleone approved these changes

Assignees

@Codelax Codelax

Labels
instance Instance issues, bugs and feature requests priority:lowest Lowest priority such as new ideas and unproved/unrequested features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Codelax @codecov-commenter @remyleone