Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for remote container building #2595

Draft
wants to merge 36 commits into
base: remote-docker
Choose a base branch
from
Draft

feat: add support for remote container building #2595

wants to merge 36 commits into from

Conversation

fenollp
Copy link

@fenollp fenollp commented Nov 18, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

@Codelax Codelax changed the base branch from master to remote-docker November 18, 2022 15:53
yfodil and others added 5 commits November 21, 2022 17:15
@yfodil @remyleone
feat(lb): improve backend get output (scaleway#2575)
08f2f0f 
Co-authored-by: Rémy Léone <rleone@scaleway.com>
@Monitob @quantumsheep
@dependabot @scaleway-bot @remyleone @Codelax
feat(rdb) add verb settings to namespace rdb engine (scaleway#2548)
bb0012c 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Nathanael Demacon <nathanael.dmc@outlook.fr>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Scaleway Bot <github@scaleway.com>
Co-authored-by: Rémy Léone <rleone@scaleway.com>
Co-authored-by: Jules Castéran <jcasteran@scaleway.com>
@scaleway-bot @Codelax
feat(iam): improve documention for DeleteUser (scaleway#2594)
c234b28 
Co-authored-by: Jules Castéran <jcasteran@scaleway.com>
@scaleway-bot @Codelax
feat(lb): add ignore ssl server verify (scaleway#2597)
0036c0f 
Co-authored-by: Jules Castéran <jcasteran@scaleway.com>
@Codelax
chore: bump go version to 1.19 (scaleway#2610)
88bcc1c
@remyleone remyleone changed the title B a a s feat: add support for remote container building Dec 1, 2022
@remyleone
Copy link
Member

Hello, I think it is an interesting contributions but I'm not too convinced on the naming and discoverability of this feature.

@remyleone remyleone marked this pull request as draft December 1, 2022 14:10
@remyleone remyleone added instance Instance issues, bugs and feature requests enhancement labels Dec 1, 2022
@remyleone remyleone self-requested a review December 1, 2022 14:11
scaleway-bot and others added 17 commits December 2, 2022 14:58
@scaleway-bot @remyleone
feat(baremetal): enable private network and options management (scale…
77118eb 
…way#2656)

Co-authored-by: Rémy Léone <rleone@scaleway.com>
@yfodil @remyleone
feat(rdb): rename ACL add/delete arguments (scaleway#2571)
77ff45b 
Co-authored-by: Rémy Léone <rleone@scaleway.com>
@yfodil
feat(rdb): improve ACL deletion message (scaleway#2669)
85c1bfb
@dependabot
chore(deps): bump golang.org/x/text from 0.4.0 to 0.5.0 (scaleway#2665)
f9eaf86
@Monitob @remyleone
feat(iam): enable iam v1alpha1 by default (scaleway#2668)
03dad56 
Co-authored-by: Rémy Léone <rleone@scaleway.com>
containerContextCreate
ae96180 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
containerContextDelete
f6c31a9 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
containerContextStop
eb128da 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
containerContextStart
805a351 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
fix docs
031fb42 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
woopsie
e359f8a 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
that validation is wrong and already performed
0818110 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
reuse block zone
ba3689b 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
use a helper
795fde4 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
use zone from server that used zone from block
3024a53 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
cloud init + start vm + poll 22 + ssh-keyscan + docker context
a48d30f 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
@Codelax
separate context (#1)
5ec4070
Pierre Fenoll added 13 commits December 8, 2022 10:27
fixup docs
2f3bba8 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
fix dialing ssh instance
1a56a09 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
set default size
e5f8d26 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
Create some block storage on the fly if none exist yet
2fddc51 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
fixup cloud init
4841622 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
tags + prompting on ssh key mgmt
1ad7dbd 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
fixes
e35f5b5 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
fixes
0475394 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
fix stopping
55d8d11 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
lessgooo
b6e139c 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
fix detaching volumes when stopping
d3b7734 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
proper error message when starting a vm with busy volume
e1c7fe4 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
fix error message
722ad57 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
CLI_UPDATE_GOLDENS=true go test ./...
ef8ad14 
Signed-off-by: Pierre Fenoll <pfenoll@scaleway.com>
@remyleone remyleone added the priority:low Low priority such as UX improvements and esthetics label Jan 25, 2023
@remyleone remyleone removed their request for review August 22, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Codelax Codelax

Labels
enhancement instance Instance issues, bugs and feature requests priority:low Low priority such as UX improvements and esthetics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fenollp @remyleone @Codelax @yfodil @Monitob @scaleway-bot