Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8s): routed ips #3154

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(k8s): routed ips #3154

wants to merge 8 commits into from

Conversation

bene2k1
Copy link
Member

@bene2k1 bene2k1 commented May 13, 2024

Your checklist for this pull request

Description

Please describe what you added or changed.

@bene2k1 bene2k1 added type: new content New pages or categories do not merge PR that shouldn't be merged before a specific date (eg release) status: draft Work in progress - do not merge or review labels May 13, 2024
@bene2k1 bene2k1 requested a review from tgenaitay May 13, 2024 09:55
@bene2k1 bene2k1 self-assigned this May 13, 2024
@bene2k1 bene2k1 added status: tech review Waiting for technical review status: doc review Waiting for doc team review and removed status: draft Work in progress - do not merge or review labels May 14, 2024
@bene2k1 bene2k1 marked this pull request as ready for review May 14, 2024 13:42
@bene2k1 @jcirinosclwy
Apply suggestions from code review
24aff52 
Co-authored-by: Jessica <113192637+jcirinosclwy@users.noreply.github.com>
@bene2k1 @nerda-codes
Apply suggestions from code review
7bf11a0 
Co-authored-by: nerda-codes <87707325+nerda-codes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgenaitay tgenaitay tgenaitay approved these changes

@nerda-codes nerda-codes nerda-codes approved these changes

@jcirinosclwy jcirinosclwy jcirinosclwy approved these changes

@RoRoJ RoRoJ Awaiting requested review from RoRoJ

Assignees

@bene2k1 bene2k1

Labels
do not merge PR that shouldn't be merged before a specific date (eg release) status: doc review Waiting for doc team review status: tech review Waiting for technical review type: new content New pages or categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bene2k1 @tgenaitay @nerda-codes @jcirinosclwy