Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[K8S] Documentation Kubernetes node images #2629

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[K8S] Documentation Kubernetes node images #2629

wants to merge 7 commits into from

Conversation

bene2k1
Copy link
Member

@bene2k1 bene2k1 commented Jan 18, 2024

Your checklist for this pull request

Description

Please describe what you added or changed.

@bene2k1 bene2k1 added type: new content New pages or categories do not merge PR that shouldn't be merged before a specific date (eg release) status: draft Work in progress - do not merge or review labels Jan 18, 2024
@bene2k1 bene2k1 self-assigned this Jan 18, 2024
louisportay
louisportay reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@louisportay louisportay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

containers/kubernetes/how-to/upgrade-kubernetes-version.mdx Outdated Show resolved Hide resolved
containers/kubernetes/reference-content/kubernetes-node-images.mdx Outdated Show resolved Hide resolved
containers/kubernetes/reference-content/kubernetes-node-images.mdx Outdated Show resolved Hide resolved
containers/kubernetes/reference-content/kubernetes-node-images.mdx Outdated Show resolved Hide resolved
containers/kubernetes/reference-content/kubernetes-node-images.mdx Show resolved Hide resolved
containers/kubernetes/reference-content/kubernetes-node-images.mdx Outdated Show resolved Hide resolved
containers/kubernetes/reference-content/kubernetes-node-images.mdx Outdated Show resolved Hide resolved
bene2k1 and others added 4 commits January 24, 2024 16:49
@bene2k1 @louisportay
Apply suggestions from code review
8236d28 
Co-authored-by: Louis Portay <20128391+louisportay@users.noreply.github.com>
@bene2k1 @louisportay
Apply suggestions from code review
21ae399 
Co-authored-by: Louis Portay <20128391+louisportay@users.noreply.github.com>
@bene2k1
feat(k8s): upgrade node pools
5665009
@bene2k1
feat(k8s): node images
00abe90
@bene2k1 bene2k1 marked this pull request as ready for review January 25, 2024 09:55
@bene2k1 bene2k1 removed the status: draft Work in progress - do not merge or review label Jan 25, 2024
@bene2k1 bene2k1 changed the title feat(k8s): kubernetes node images [K8S] Documentation Kubernetes node images Jan 31, 2024
@tgenaitay
Copy link
Member

This documentation is STAND BY until the node image gets out of BETA and generalized (probably not until kubernetes 1.31).
Let's wait until the benefits of this system have been proven and measured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgenaitay tgenaitay tgenaitay left review comments

@louisportay louisportay louisportay left review comments

@jcirinosclwy jcirinosclwy jcirinosclwy approved these changes

@RoRoJ RoRoJ Awaiting requested review from RoRoJ

At least 2 approving reviews are required to merge this pull request.

Assignees

@bene2k1 bene2k1

Labels
do not merge PR that shouldn't be merged before a specific date (eg release) type: new content New pages or categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bene2k1 @tgenaitay @louisportay @jcirinosclwy