-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: x-displayName & x-tagGroups cancel eachother out, fix #1719 #1725
Conversation
🦋 Changeset detectedLatest commit: 82bcbb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
#1540 Bundle Size — 1.8MiB (~+0.01%).Warning Bundle contains 4 duplicate packages – View duplicate packages Bundle metrics
|
Current #1540 |
Baseline #1536 |
|
---|---|---|
Initial JS | 1.8MiB (~+0.01% ) |
1.8MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 100% |
0% |
Chunks | 1 |
1 |
Assets | 1 |
1 |
Modules | 1073 |
1073 |
Duplicate Modules | 0 |
0 |
Duplicate Code | 0% |
0% |
Packages | 160 |
160 |
Duplicate Packages | 4 |
4 |
Bundle analysis report Branch fix/x-display-name-and-x-tag-gro... Project dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't expect to wake up to see my issue already fixed, thank you!
I had a look at the changes and tested the preview deployment, everything LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ nice reporting @edorgeville and awesome fix @hanspagel !
ah! some conflicts @hanspagel then we can get this in ✨ |
90a9fb4
to
82bcbb6
Compare
Preview deployed to https://51022210-ad20-4727-abf2-7165e195f5d1--scalar-deploy-preview.netlify.app |
Currently,
x-displayName
andx-tagGroups
don’t play well with each other, see #1719.This PR fixes it. Instead of overwriting the name, and breaking the logic of what belongs to which tag, we’ll just keep an optional
displayTitle
which is used to overwritetitle
(if needed).Example
Result