-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow json primitives as valid json objects #1411
Conversation
🦋 Changeset detectedLatest commit: 8542698 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
#1100 Bundle Size — 1.92MiB (~+0.01%).Warning Bundle contains 4 duplicate packages – View duplicate packages Bundle metrics
|
Current #1100 |
Baseline #1098 |
|
---|---|---|
Initial JS | 1.92MiB (~+0.01% ) |
1.92MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 100% |
0% |
Chunks | 1 |
1 |
Assets | 1 |
1 |
Modules | 1049 |
1049 |
Duplicate Modules | 0 |
0 |
Duplicate Code | 0% |
0% |
Packages | 158 |
158 |
Duplicate Packages | 4 |
4 |
Bundle analysis report Branch brynn/doc-1675-allow-json-primit... Project dashboard
@marclave we may want to consider this but it will have significant downstream impacts as "AnyObject" is not the true valid return type of I am also a little confused about the original issue as it looks like their request was using |
85941b1
to
8542698
Compare
Going to close this for now until @geoffgscott gets a chance to chat with @marclave @hanspagel about how we want to proceed |
@hanspagel We should take a look at how to get this in safely |
I think we should focus on the shift to the new proxy first (because it affects basically all users) and get this PR here in after we’ve migrated to the new proxy. |
I think I fixed this here today: #1090 I saw a few duplicate lines that looked like the result of a merge conflict. |
Fixes #1396