Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Algolia credentials #2569

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tgodzik
Copy link
Collaborator

@tgodzik tgodzik commented Feb 2, 2022

No description provided.

@tgodzik tgodzik requested a review from olafurpg February 2, 2022 15:10
@kitbellew
Copy link
Contributor

you have something which adds trailing commas...

@tgodzik
Copy link
Collaborator Author

tgodzik commented Feb 2, 2022

you have something which adds trailing commas...

That would be prettier and I think that's the default style in javascript?

@kitbellew
Copy link
Contributor

you have something which adds trailing commas...

That would be prettier and I think that's the default style in javascript?

i don't disagree :)

Copy link
Contributor

@kitbellew kitbellew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, and tests pass, even though i don't fully understand the significance of the apiKey change (or appId) introduction.

@tgodzik
Copy link
Collaborator Author

tgodzik commented Feb 2, 2022

this looks good to me, and tests pass, even though i don't fully understand the significance of the apiKey change (or appId) introduction.

apparently that's a change needed for the search bar to work, but I am not sure exactly how that works 😅

I'll wait for @olafurpg to take a look.

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API key and app ID looks correct. However, I can't find the "scalameta" application in my algolia account so I don't know if the index has been enabled yet. I sent an email to Algolia DocSearch requesting to add you @tgodzik to all of the Scalameta-related Algolia apps. We may want to wait with merging this PR until we hear back from them

@kitbellew
Copy link
Contributor

The API key and app ID looks correct. However, I can't find the "scalameta" application in my algolia account so I don't know if the index has been enabled yet. I sent an email to Algolia DocSearch requesting to add you @tgodzik to all of the Scalameta-related Algolia apps. We may want to wait with merging this PR until we hear back from them

@tgodzik any news on this?

@tgodzik
Copy link
Collaborator Author

tgodzik commented Jan 10, 2023

The API key and app ID looks correct. However, I can't find the "scalameta" application in my algolia account so I don't know if the index has been enabled yet. I sent an email to Algolia DocSearch requesting to add you @tgodzik to all of the Scalameta-related Algolia apps. We may want to wait with merging this PR until we hear back from them

@tgodzik any news on this?

No update, I think we need to redo the indexes with a new account for algolia.

tanishiking added a commit to tanishiking/metals that referenced this pull request Mar 19, 2023
We've been working on updating the algolia index for scalameta sites.
However, there's been a lot of trouble keeping the algolia keys up to date,
and the search function sometimes goes down.
see:
scalacenter/scalafix#1514
scalameta#3604
scalameta/scalameta#2569

This commit switches the search function from algolia to one of the
local search indexes
https://github.com/cmfcmf/docusaurus-search-local
chosen from
https://docusaurus.io/community/resources#search

ggl#
tanishiking added a commit to tanishiking/metals that referenced this pull request Mar 19, 2023
We've been working on updating the algolia index for scalameta sites.
However, there's been a lot of trouble keeping the algolia keys up to date,
and the search function sometimes goes down.
see:
scalacenter/scalafix#1514
scalameta#3604
scalameta/scalameta#2569

This commit switches the search function from algolia to one of the
local search indexes
https://github.com/cmfcmf/docusaurus-search-local
chosen from
https://docusaurus.io/community/resources#search

I picked cmfcmf/docusaurus-search-local because
it has a lot of stars + it seems to be well maintained
Maybe there's better alternative :)
tanishiking added a commit to tanishiking/metals that referenced this pull request Mar 19, 2023
We've been working on updating the algolia index for scalameta sites.
However, there's been a lot of trouble keeping the algolia keys up to date,
and the search function sometimes goes down.
see:
scalacenter/scalafix#1514
scalameta#3604
scalameta/scalameta#2569

This commit switches the search function from algolia to one of the
local search indexes
https://github.com/cmfcmf/docusaurus-search-local
chosen from
https://docusaurus.io/community/resources#search

I picked cmfcmf/docusaurus-search-local because

- it seems to be well maintained
- it works without server setup (unlike typesense)

but, other suggestions are welcome :)
tanishiking added a commit to tanishiking/metals that referenced this pull request Mar 19, 2023
We've been working on updating the algolia index for scalameta sites.
However, there's been a lot of trouble keeping the algolia keys up to date,
and the search function sometimes goes down.
see:
scalacenter/scalafix#1514
scalameta#3604
scalameta/scalameta#2569

This commit switches the search function from algolia to one of the
local search indexes
https://github.com/easyops-cn/docusaurus-search-local
chosen from
https://docusaurus.io/community/resources#search

I picked easyops-cn/docusaurus-search-local because

- it seems to be well maintained
- it works without server setup (unlike typesense)
- looks prettier than cmfcmf/docusaurus-search-local (original one)

but, other suggestions are welcome :)
tanishiking added a commit to tanishiking/metals that referenced this pull request Mar 19, 2023
We've been working on updating the algolia index for scalameta sites.
However, there's been a lot of trouble keeping the algolia keys up to date,
and the search function sometimes goes down.
see:
scalacenter/scalafix#1514
scalameta#3604
scalameta/scalameta#2569

This commit switches the search function from algolia to one of the
local search indexes
https://github.com/easyops-cn/docusaurus-search-local
chosen from
https://docusaurus.io/community/resources#search

I picked easyops-cn/docusaurus-search-local because

- it seems to be well maintained
- it works without server setup (unlike typesense)
- looks prettier than cmfcmf/docusaurus-search-local (original one)

but, other suggestions are welcome :)
tgodzik pushed a commit to scalameta/metals that referenced this pull request Mar 20, 2023
We've been working on updating the algolia index for scalameta sites.
However, there's been a lot of trouble keeping the algolia keys up to date,
and the search function sometimes goes down.
see:
scalacenter/scalafix#1514
#3604
scalameta/scalameta#2569

This commit switches the search function from algolia to one of the
local search indexes
https://github.com/easyops-cn/docusaurus-search-local
chosen from
https://docusaurus.io/community/resources#search

I picked easyops-cn/docusaurus-search-local because

- it seems to be well maintained
- it works without server setup (unlike typesense)
- looks prettier than cmfcmf/docusaurus-search-local (original one)

but, other suggestions are welcome :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants