Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revising Traversables.scala groupBy example #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revising Traversables.scala groupBy example #128

wants to merge 1 commit into from

Conversation

ArkadiuszChudoba
Copy link

There were two problems with groupBy example:

  1. It didn't work properly for negative numbers.
  2. partial functions were unnecessarily complicated as we could use the fact that we chain partial functions. This has added benefit of showing how partial functions can be chained to perform more specific grouping.

@ArkadiuszChudoba
Fixing Traversables.scala groupBy example
9fa4664 
There were two problems with groupBy example:
1. It didn't work properly for negative numbers.
2. partial functions were unnecessarily complicated as we could use the fact that we chain partial functions.  This has added benefit of showing how partial functions can be chained to perform more specific grouping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ArkadiuszChudoba