Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead symlink handling #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adeutscher
Copy link

@adeutscher adeutscher commented Feb 19, 2020

Add handling for dead symbolic links. Fixes: #6, #19

@adeutscher
Copy link
Author

I'm not certain about is the icon choice for a link. Not familiar enough with FontAwesome.

This PR also adds a few new properties (is_symlink and exists) that can be used in the display template.

…nd correct a problem in this branch with processing subdirectories
@adeutscher
Copy link
Author

#19 ended up being due to another type of unreachable symbolic link, so adding the fix into this branch.

The cause of the issue is that the is_dir/is_file methods of DirEntry throw PermissionErrors when used on a walled-off symbolic link.

@adeutscher
Copy link
Author

Phrasing question: "Dead Symbolic Link" or "Unreachable Symbolic Link"? I'm used to saying "dead", but that could just be a casual habit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dead Symlink Handling
1 participant