Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for existing SSL certificates #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

owIsec
Copy link

@owIsec owIsec commented Mar 20, 2021

As requested in #28, custom SSL certificate functionality is trivial with the werkzeug.serving.run_simple function.

Tested by generating SSL certificates with the command:
openssl req -x509 -days 365 -newkey rsa:2048 -keyout test-ssl.key -out test-ssl.crt

@sc0tfree
Copy link
Owner

I like this option for sure.

Since you're dealing with paths, this needs to be reflected in a few areas. Most notably, in a validator function within argparse. This needs to be OS-independent as well, using os.path (although I should probably move to pathlib entirely). Also, --sslcert and --sslkey need to throw an error if not used together.

I'm sure I'm missing more edge cases!

@patrickhener
Copy link

This one can do it: https://github.com/patrickhener/goshs

pantsmanuk added a commit to pantsmanuk/updog that referenced this pull request Apr 5, 2022
As per sc0tfree#32, added logic to ensure that both --cert and --key arguments are supplied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants