-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testsbxml #89
Add testsbxml #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skeating i can understand why these changes are necessary. I would just want to ask you to first tag the release branch before the merge, as the generated code is not compatible with what was generated before. So we need an update to VERSION.txt
and a tag. then I'd be happy to approve.
Ideally the cmake code would be updated to current CMake (i.e. using import targets that contain the include directory and flags needed to build) that would simplify the code changes a bit. But that can come in later.
i hope that is ok
tagged existing dev branch and changed version here to 2.0 |
@fbergmann happy for me to merge now ? other PRs I'll get reviewed here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much for the new tag.
Description
Adding testsbxml as a test-other library test
and changing test files affected
Motivation and Context
Types of changes
Checklist: