Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testsbxml #89

Merged
merged 15 commits into from
May 23, 2023
Merged

Add testsbxml #89

merged 15 commits into from
May 23, 2023

Conversation

skeating
Copy link
Member

Description

Adding testsbxml as a test-other library test
and changing test files affected

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

@skeating skeating marked this pull request as draft September 22, 2021 14:09
@skeating skeating requested a review from fbergmann May 22, 2023 08:22
@skeating skeating marked this pull request as ready for review May 22, 2023 08:22
Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skeating i can understand why these changes are necessary. I would just want to ask you to first tag the release branch before the merge, as the generated code is not compatible with what was generated before. So we need an update to VERSION.txt and a tag. then I'd be happy to approve.

Ideally the cmake code would be updated to current CMake (i.e. using import targets that contain the include directory and flags needed to build) that would simplify the code changes a bit. But that can come in later.

i hope that is ok

@skeating skeating requested a review from fbergmann May 22, 2023 14:49
@skeating
Copy link
Member Author

tagged existing dev branch and changed version here to 2.0

@skeating
Copy link
Member Author

@fbergmann happy for me to merge now ?

other PRs I'll get reviewed here

Copy link
Member

@fbergmann fbergmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for the new tag.

@skeating skeating merged commit d35818b into develop May 23, 2023
36 checks passed
@skeating skeating deleted the add_testsbxml branch May 23, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants