Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #7

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

VasilyKaiser
Copy link

Added support for Windows

Restrictions:

  • Powershell needs elevated privilege to run "Get-Process" with "-IncludeUserName" parameter.
    • If run withing non privileged session, usernames will not appear.

Problems:

  • Trying to kill ports using filter causes panic

    Caught panic:
    
    runtime error: invalid memory address or nil pointer dereference
    
    Restoring terminal...
    
    goroutine 1 [running]:
    runtime/debug.Stack()
            C:/Program Files/Go/src/runtime/debug/stack.go:24 +0x65
    runtime/debug.PrintStack()
            C:/Program Files/Go/src/runtime/debug/stack.go:16 +0x19
    github.com/charmbracelet/bubbletea.(*Program).Run.func1()
            C:/Users/vujov/go/pkg/mod/github.com/charmbracelet/bubbletea@v0.23.2/tea.go:402 +0x95
    panic({0x1170100, 0x131f7f0})
            C:/Program Files/Go/src/runtime/panic.go:890 +0x263
    main.model.Update({{0x0, 0x1, 0x1, 0x1, 0x1, 0x1, {0x1197d1c, 0x7}, {0x1198537, 0x9}, ...}, ...}, ...)
            D:/GitHub/gruyere/main.go:110 +0x596
    github.com/charmbracelet/bubbletea.(*Program).eventLoop(0xc00018c000, {0x11dc478?, 0xc000071b00?}, 0x100458a?)
            C:/Users/vujov/go/pkg/mod/github.com/charmbracelet/bubbletea@v0.23.2/tea.go:343 +0x60a
    github.com/charmbracelet/bubbletea.(*Program).Run(0xc00018c000)
            C:/Users/vujov/go/pkg/mod/github.com/charmbracelet/bubbletea@v0.23.2/tea.go:465 +0x81d
    main.main()
            D:/GitHub/gruyere/main.go:178 +0x285
    
  • UI is messed up on Windows terminals

image

@savannahostrowski
Copy link
Owner

I don't quite have the bandwidth to debug this right now. Would be happy to have someone take it to the finish line though.

@savannahostrowski
Copy link
Owner

savannahostrowski commented May 8, 2023

I'm going to convert this to a draft PR for now, until someone can help take it to the finish line for Windows or until I have a chance to take a look (hope that's okay!)

Related issue: #6

@savannahostrowski savannahostrowski marked this pull request as draft May 8, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants