Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to restore high res image import. #8383

Closed
wants to merge 1 commit into from

Conversation

kimsjune
Copy link

This aims to fix #8381 by restoring image.name option for readPNG() and consequently Read10X_Image(). The master branch version has "tissue_lowres_image.png" hard-coded. This was not the case in an earlier version, so I just copied it back. There is a scale factor error if the high res image is used, which can be mitigated by:

hires <- Read10X_Image(paste0(data.dir,'spatial',sep=''),image.name='tissue_hires_image.png')
hires@scale.factors$lowres = hires@scale.factors$hires

Also mentioned here.

Hope this can help.

@dcollins15
Copy link
Contributor

Thanks for the PR!

We restored the image.name parameter for Read10X_Spatial in v5.1.0 per your suggestion 👍

We've also introduced the image.scale parameter to SpatialDimPlot and SpatialFeaturePlot so that you can select the appropriate scale factor to use for your image. Closing this PR since the feature has been implemented

We're always appreciative of contributions from external collaborators - thanks again!

@dcollins15 dcollins15 closed this May 10, 2024
@kimsjune kimsjune deleted the dev branch May 11, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants