feat(decorators): update decorators to new ECMAScript proposal #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: @sapphire/ts-config now relies on TypeScript v5.x. DO NOT attempt to use this version with TypeScript v4.x or lower. DO NOT attempt to use a previous major with TypeScript v5.x.
BREAKING CHANGE: the config `@sapphire/ts-config/extra-strict-without-decorators` has been removed this because decorators are now a core part of TypeScript and are no longer experimental replace your extends with `@sapphire/ts-config/extra-strict` to regain the same functionality
BREAKING CHANGE: The previous version had `"module": "CommonJS"` whereas this one has `"module": "Node16"`. Refer to the TypeScript documentation for the differences
This was exposed by `verbatimModuleSyntax`
This was exposed by `verbatimModuleSyntax`
BREAKING CHANGE: the config `@sapphire/ts-config/without-decorators` has been removed this because decorators are now a core part of TypeScript and are no longer experimental replace your extends with `@sapphire/ts-config` to regain the same functionality
This was exposed by `verbatimModuleSyntax`
This was exposed by `verbatimModuleSyntax`
This was exposed by `verbatimModuleSyntax`
BREAKING CHANGE: DO NOT attempt to use this version with TypeScript 4.x, it will not work! BREAKING CHANGE: `EnumerableMethod` is gone, it never really worked anyway BREAKING CHANGE: `Enumerable` now has to be applied to both fields and classes for it to work BREAKING CHANGE: Typings have generally overall changed
favna
force-pushed
the
feat/typescript-v5
branch
2 times, most recently
from
d2cebb4
to
3bacf70
Compare
favna
force-pushed
the
feat/typescript-v5
branch
4 times, most recently
from
298bd78
to
6a2b3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: DO NOT attempt to use this version with TypeScript 4.x, it will not work!
BREAKING CHANGE:
EnumerableMethodis gone, it never really worked anywayBREAKING CHANGE:
Enumerablenow has to be applied to both fields and classes for it to workBREAKING CHANGE: Typings have generally overall changed