Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: captures error message fields in struct #99

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

santhosh-tekuri
Copy link
Owner

closes Issue #44

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023

Codecov Report

Base: 91.66% // Head: 91.66% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (be93380) compared to base (2dc9222).
Patch coverage: 96.96% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   91.66%   91.66%   -0.01%     
==========================================
  Files          10       10              
  Lines        2545     2542       -3     
==========================================
- Hits         2333     2330       -3     
  Misses        164      164              
  Partials       48       48              
Impacted Files Coverage Δ
output.go 0.00% <0.00%> (ø)
errors.go 85.29% <100.00%> (+0.21%) ⬆️
extension.go 14.81% <100.00%> (ø)
schema.go 98.69% <100.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@akshetpandey
Copy link

akshetpandey commented Mar 24, 2023

@santhosh-tekuri : What is needed to land this diff? I can help.

@santhosh-tekuri
Copy link
Owner Author

santhosh-tekuri commented Mar 24, 2023

@akshetpandey
you can use v6.0.0-alpha.1 if you need this change.

currently I am porting this to rust https://github.com/santhosh-tekuri/boon and found some bugs and some improvements which also require incompatible changes.

so I am holding on so that I can do all incompatible changes in single major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants