Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support truncated output and validation error should write in buffer #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zedongh
Copy link

@zedongh zedongh commented Mar 15, 2023

for large file validation will cause mess error and output will be huge:

  1. support tuncated output should first level validation error
  2. validationError GoString concat using byte Buffer for better performance

@santhosh-tekuri
Copy link
Owner

could you please create individual PR for each commit.

regarding the truncated output, it needs some evaluation from my side and takes time.

since GoString change is simpler and straight forward, having separate PR will help in merge early;

@zedongh
Copy link
Author

zedongh commented Mar 15, 2023

ok,my pleasure here #111

And, for truncate commit, hope jv support -flag truncate, print few error and stop, rather than print all of error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants