Typecheck: Disable strictNullChecks #3668
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah, and bypassing this got me to the actual error Kenton found when he was trying to test: https://github.com/sandstorm-io/sandstorm/actions/runs/3239675622/jobs/5309339670#step:12:436 Whole onion of test failures. Gotta get past the intermittent node-capnp to find the typecheck issue, gotta get past the typecheck issue to get child_process, etc. |
|
I'd rather not fix it this way; strict null checking is the sort of thing that has the potential to catch a lot of real bugs. |
|
Entirely fair: I opened this to document to abuse the CI for testing and leave notes. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for the failure of typecheck-ts. (We could also locked TypeScript down to 4.7.x, or fix the issues in question, of course...
I believe the new errors were caused due to: https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#unconstrained-generics-no-longer-assignable-to and this is an example of another project fixing their compatibility with 4.8: prisma/prisma#15072 which I feel may be useful reference if someone wants to tackle this "correctly".